Tentative solution to pytree#27
Merged
Merged
Conversation
mavenlin
commented
Aug 22, 2025
Owner
|
ah this is a cute idea. i like it if it works! so iiuc the idea is that we replace torch2jax/torch2jax/__init__.py Lines 1174 to 1175 in bee0974 _tree_coerce and then it automatically handles pytorch pytree types as we encounter them? i wonder if this will work inside of jax.jit?
|
mavenlin
force-pushed
the
pytree
branch
3 times, most recently
from
August 23, 2025 14:06
b39a65a to
aa7f23f
Compare
Contributor
Author
|
This PR is the prerequisite for functions like |
samuela
reviewed
Aug 30, 2025
samuela
left a comment
samuela
left a comment
Owner
There was a problem hiding this comment.
this contains a lot of formatting changes that have no impact on functionality. let's remove those before merging
Owner
|
this is a cleaner solution than i thought would be possible, thanks @mavenlin ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may move the discussions on pytree here, there are some future PRs that would depend on a systematic solution of this.